HyukjinKwon commented on code in PR #39743:
URL: https://github.com/apache/spark/pull/39743#discussion_r1087283667
##########
python/pyspark/sql/tests/connect/test_connect_function.py:
##########
@@ -15,44 +15,31 @@
# limitations under the License.
#
import unittest
-import tempfile
from pyspark.errors import PySparkTypeError
-from pyspark.sql import SparkSession
+from pyspark.sql import SparkSession as PySparkSession
from pyspark.sql.types import StringType, StructType, StructField, ArrayType,
IntegerType
from pyspark.testing.pandasutils import PandasOnSparkTestCase
-from pyspark.testing.connectutils import should_test_connect,
connect_requirement_message
-from pyspark.testing.utils import ReusedPySparkTestCase
+from pyspark.testing.connectutils import ReusedConnectTestCase
from pyspark.testing.sqlutils import SQLTestUtils
from pyspark.errors import SparkConnectAnalysisException, SparkConnectException
-if should_test_connect:
- from pyspark.sql.connect.session import SparkSession as RemoteSparkSession
-
-@unittest.skipIf(not should_test_connect, connect_requirement_message)
-class SparkConnectFuncTestCase(PandasOnSparkTestCase, ReusedPySparkTestCase,
SQLTestUtils):
- """Parent test fixture class for all Spark Connect related
- test cases."""
+class SparkConnectFunctionTests(ReusedConnectTestCase, PandasOnSparkTestCase,
SQLTestUtils):
+ """These test cases exercise the interface to the proto plan
+ generation but do not call Spark."""
@classmethod
def setUpClass(cls):
- ReusedPySparkTestCase.setUpClass()
- cls.tempdir = tempfile.NamedTemporaryFile(delete=False)
- cls.hive_available = True
- # Create the new Spark Session
- cls.spark = SparkSession(cls.sc)
- # Setup Remote Spark Session
- cls.connect = RemoteSparkSession.builder.remote().getOrCreate()
+ super(SparkConnectFunctionTests, cls).setUpClass()
+ cls.connect = cls.spark # Switch Spark Connect session and regular
PySpark sesion.
+ cls.spark = PySparkSession._instantiatedSession
+ assert cls.spark is None
Review Comment:
```suggestion
assert cls.spark is not None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
