[GitHub] [spark] vinodkc commented on a diff in pull request #39449: [SPARK-40688][SQL] Support data masking built-in function 'mask_first_n'

[via GitHub]

vinodkc commented on code in PR #39449:
URL: https://github.com/apache/spark/pull/39449#discussion_r1087343461


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala:
##########
@@ -283,7 +543,32 @@ object Mask {
         transformChar(_, maskUpper, maskLower, maskDigit, maskOther).toChar
       }
     }
-    org.apache.spark.unsafe.types.UTF8String.fromString(transformedString)
+    UTF8String.fromString(transformedString)
+  }
+
+  def mask_first_n(
+      input: Any,
+      charCount: Int,
+      maskUpper: Any,
+      maskLower: Any,
+      maskDigit: Any,
+      maskOther: Any): UTF8String = {
+
+    val transformedString = if (input == null) {
+      null
+    } else {
+      val inputStr = input.asInstanceOf[UTF8String]
+      val stringSize = inputStr.numChars
+      val endIdx = if (stringSize < charCount) stringSize else charCount

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org