cloud-fan commented on code in PR #39508: URL: https://github.com/apache/spark/pull/39508#discussion_r1089960001
########## sql/core/src/test/resources/sql-tests/inputs/column-resolution-aggregate.sql: ########## @@ -0,0 +1,30 @@ +-- Tests covering column resolution priority in Aggregate. Review Comment: @anchovYu can you help review the new tests? I think I've covered all the cases. ########## sql/core/src/test/resources/sql-tests/inputs/column-resolution-sort.sql: ########## @@ -0,0 +1,20 @@ +--SET spark.sql.leafNodeDefaultParallelism=1 +-- Tests covering column resolution priority in Sort. Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
