vinodkc commented on code in PR #38419:
URL: https://github.com/apache/spark/pull/38419#discussion_r1096438825
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala:
##########
@@ -331,6 +332,275 @@ case class RoundCeil(child: Expression, scale: Expression)
copy(child = newLeft, scale = newRight)
}
+
+/**
+ * Truncates a number to the specified number of digits.
+ * @param child
+ * expression to get the number to be truncated.
+ * @param scale
+ * expression to get the number of decimal places to truncate to.
+ */
+case class TruncNumber(child: Expression, scale: Expression)
+ extends BaseBinaryExpression
+ with NullIntolerant {
+
+ override protected def withNewChildrenInternal(
+ newLeft: Expression,
+ newRight: Expression): TruncNumber = copy(child = newLeft, scale =
newRight)
+
+ /**
+ * Returns the [[DataType]] of the result of evaluating this expression. It
is invalid to query
Review Comment:
Done
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala:
##########
@@ -331,6 +332,275 @@ case class RoundCeil(child: Expression, scale: Expression)
copy(child = newLeft, scale = newRight)
}
+
+/**
+ * Truncates a number to the specified number of digits.
+ * @param child
+ * expression to get the number to be truncated.
+ * @param scale
+ * expression to get the number of decimal places to truncate to.
+ */
+case class TruncNumber(child: Expression, scale: Expression)
+ extends BaseBinaryExpression
+ with NullIntolerant {
+
+ override protected def withNewChildrenInternal(
+ newLeft: Expression,
+ newRight: Expression): TruncNumber = copy(child = newLeft, scale =
newRight)
+
+ /**
+ * Returns the [[DataType]] of the result of evaluating this expression. It
is invalid to query
+ * the dataType of an unresolved expression (i.e., when `resolved` == false).
+ */
+ override lazy val dataType: DataType = child.dataType
+
+ /**
+ * This overridden implementation delegates the overloaded TruncNumber.trunc
methods based on
+ * data type of input values
+ */
+ override protected def nullSafeEval(input1: Any, input2: Any): Any = {
+ (dataType, input1) match {
+ // Trunc function accepts a second parameter to truncate the input
number.
+ // If 0, it removes all the decimal values and returns only the integer.
+ // If negative, the number is truncated to the left side of the decimal
point.
+ // Value of decimal places to truncate can range from -ve to +ve
+ // 1) In the case of integral numbers, as there is no decimal part if
the value of decimal
+ // places to truncate is +ve, then we can return that input value
without any
+ // modification as there is no +ve decimal place to be truncated from an
integral number
+ // Truncate the input only if the value of decimal places to truncate is
< 0
+ case (ByteType, input: Byte) if (scaleValue < 0) =>
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
