LuciferYang commented on code in PR #40069: URL: https://github.com/apache/spark/pull/40069#discussion_r1110563308
########## sql/catalyst/src/main/scala/org/apache/spark/sql/util/PartitioningUtils.scala: ########## @@ -30,6 +30,7 @@ import org.apache.spark.sql.types.{CharType, DataType, StringType, StructField, import org.apache.spark.unsafe.types.UTF8String private[sql] object PartitioningUtils { + private val PATTERN_FOR_KEY_EQ_VAL = "(.+)=(.+)".r Review Comment: I remember seeing similar cases in the production environment, but I can't remember the details. Need to have tests to check the corner scenes we can think of cc @wangyum @sunchao FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org