amaliujia commented on code in PR #40164:
URL: https://github.com/apache/spark/pull/40164#discussion_r1117849043
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2461,6 +2461,60 @@ class Dataset[T] private[sql] (val session:
SparkSession, private[sql] val plan:
new DataFrameWriterV2[T](table, this)
}
+ def unpersist(blocking: Boolean): this.type = {
+ throw new UnsupportedOperationException("unpersist() is not implemented.")
+ }
+
+ def unpersist(): this.type = unpersist(blocking = false)
+
+ def cache(): this.type = {
+ throw new UnsupportedOperationException("cache() is not implemented.")
+ }
+
+ def withWatermark(eventTime: String, delayThreshold: String): Dataset[T] = {
+ throw new UnsupportedOperationException("withWatermark is not
implemented.")
+ }
+
+ def observe(name: String, expr: Column, exprs: Column*): Dataset[T] = {
+ throw new UnsupportedOperationException("observe is not implemented.")
+ }
+
+ def foreach(f: T => Unit): Unit = {
+ throw new UnsupportedOperationException("foreach is not implemented.")
+ }
+
+ def foreachPartition(f: Iterator[T] => Unit): Unit = {
+ throw new UnsupportedOperationException("foreach is not implemented.")
+ }
+
+ def checkpoint(): Dataset[T] = {
+ throw new UnsupportedOperationException("checkpoint is not implemented.")
+ }
+
+ def checkpoint(eager: Boolean): Dataset[T] = {
+ throw new UnsupportedOperationException("checkpoint is not implemented.")
+ }
+
+ def localCheckpoint(): Dataset[T] = {
+ throw new UnsupportedOperationException("localCheckpoint is not
implemented.")
+ }
+
+ def localCheckpoint(eager: Boolean): Dataset[T] = {
+ throw new UnsupportedOperationException("localCheckpoint is not
implemented.")
+ }
+
+ def sameSemantics(other: Dataset[T]): Boolean = {
Review Comment:
This seems not to be un-implementable. Maybe deal with it seperately?
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2461,6 +2461,60 @@ class Dataset[T] private[sql] (val session:
SparkSession, private[sql] val plan:
new DataFrameWriterV2[T](table, this)
}
+ def unpersist(blocking: Boolean): this.type = {
+ throw new UnsupportedOperationException("unpersist() is not implemented.")
+ }
+
+ def unpersist(): this.type = unpersist(blocking = false)
+
+ def cache(): this.type = {
+ throw new UnsupportedOperationException("cache() is not implemented.")
+ }
+
+ def withWatermark(eventTime: String, delayThreshold: String): Dataset[T] = {
+ throw new UnsupportedOperationException("withWatermark is not
implemented.")
+ }
+
+ def observe(name: String, expr: Column, exprs: Column*): Dataset[T] = {
+ throw new UnsupportedOperationException("observe is not implemented.")
+ }
+
+ def foreach(f: T => Unit): Unit = {
+ throw new UnsupportedOperationException("foreach is not implemented.")
+ }
+
+ def foreachPartition(f: Iterator[T] => Unit): Unit = {
+ throw new UnsupportedOperationException("foreach is not implemented.")
+ }
+
+ def checkpoint(): Dataset[T] = {
+ throw new UnsupportedOperationException("checkpoint is not implemented.")
+ }
+
+ def checkpoint(eager: Boolean): Dataset[T] = {
+ throw new UnsupportedOperationException("checkpoint is not implemented.")
+ }
+
+ def localCheckpoint(): Dataset[T] = {
+ throw new UnsupportedOperationException("localCheckpoint is not
implemented.")
+ }
+
+ def localCheckpoint(eager: Boolean): Dataset[T] = {
+ throw new UnsupportedOperationException("localCheckpoint is not
implemented.")
+ }
+
+ def sameSemantics(other: Dataset[T]): Boolean = {
Review Comment:
This seems not to be un-implementable. Maybe deal with it separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
