hvanhovell commented on code in PR #40228:
URL: https://github.com/apache/spark/pull/40228#discussion_r1125208793
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2724,8 +2724,20 @@ class Dataset[T] private[sql] (
throw new UnsupportedOperationException("localCheckpoint is not
implemented.")
}
+ /**
+ * Returns `true` when the logical query plans inside both [[Dataset]]s are
equal and
+ * therefore return same results.
+ *
+ * @note The equality comparison here is simplified by tolerating the
cosmetic differences
+ * such as attribute names.
+ * @note This API can compare both [[Dataset]]s very fast but can still
return `false` on
Review Comment:
Update this comment? The comparison won't be fast. Maybe add a note here to
explain that this executes a RPC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
