panbingkun commented on code in PR #40280: URL: https://github.com/apache/spark/pull/40280#discussion_r1125590273
########## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ########## @@ -115,7 +115,7 @@ class SparkSession private[sql] ( private def createDataset[T](encoder: AgnosticEncoder[T], data: Iterator[T]): Dataset[T] = { newDataset(encoder) { builder => val localRelationBuilder = builder.getLocalRelationBuilder - .setSchema(encoder.schema.catalogString) Review Comment: Should I change `json` to `toDDL`, or is `json` actually OK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org