hvanhovell commented on code in PR #40277:
URL: https://github.com/apache/spark/pull/40277#discussion_r1125835789
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -140,6 +141,21 @@ message Read {
// (Optional) A list of path for file-system backed data sources.
repeated string paths = 4;
}
+
+ message PartitionedJDBC {
+ // (Required) JDBC URL.
+ string url = 1;
+
+ // (Required) Name of the table in the external database.
+ string table = 2;
+
+ // (Optional) Condition in the where clause for each partition.
+ repeated string predicates = 3;
Review Comment:
Can we just put the predicates into the DataSource message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
