pan3793 commented on code in PR #40283: URL: https://github.com/apache/spark/pull/40283#discussion_r1125930947
########## build/mvn: ########## @@ -119,7 +119,8 @@ install_mvn() { if [ "$MVN_BIN" ]; then local MVN_DETECTED_VERSION="$(mvn --version | head -n1 | awk '{print $3}')" fi - if [ $(version $MVN_DETECTED_VERSION) -lt $(version $MVN_VERSION) ]; then Review Comment: I'm change `-lt` to `-ne`, and always respect `maven.version` defined in `pom.xml` ########## build/mvn: ########## @@ -119,7 +119,8 @@ install_mvn() { if [ "$MVN_BIN" ]; then local MVN_DETECTED_VERSION="$(mvn --version | head -n1 | awk '{print $3}')" fi - if [ $(version $MVN_DETECTED_VERSION) -lt $(version $MVN_VERSION) ]; then Review Comment: I mean change `-lt` to `-ne`, and always respect `maven.version` defined in `pom.xml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org