aokolnychyi commented on code in PR #40308: URL: https://github.com/apache/spark/pull/40308#discussion_r1127343402
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala: ########## @@ -129,7 +129,7 @@ object TableOutputResolver { } } - private def checkNullability( + private[analysis] def checkNullability( Review Comment: I want to reuse code from `TableOutputResolver` wherever possible. However, adding assignment processing directly there would make that class even more complicated than it is today. That's why I decided to open up some methods instead. Feedback is appreciated. I could add `applyUpdate` to `TableOutputResolver` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org