mridulm commented on code in PR #40307:
URL: https://github.com/apache/spark/pull/40307#discussion_r1128807716
##########
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala:
##########
@@ -456,7 +456,9 @@ class SparkListenerSuite extends SparkFunSuite with
LocalSparkContext with Match
val conf = new SparkConf().setMaster("local").setAppName("test")
.set(EXTRA_LISTENERS, listeners.map(_.getName))
sc = new SparkContext(conf)
- sc.listenerBus.listeners.asScala.count(_.isInstanceOf[BasicJobCounter])
should be (1)
+ // sc.listenerBus.listeners.asScala.count(_.isInstanceOf[BasicJobCounter])
should be (1)
+
assert(sc.listenerBus.listeners.asScala.count(_.isInstanceOf[BasicJobCounter])
== 1,
+ s"listeners = ${sc.listenerBus.listeners.asScala.mkString(", ")}")
Review Comment:
This change, and the change to LogUrlsStaqndaloneSuite was to debug why
these assertions failed.
But looks like it is just flakey test probably (on my local box) - so
removing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
