aokolnychyi commented on code in PR #40308:
URL: https://github.com/apache/spark/pull/40308#discussion_r1128943046
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3344,43 +3345,6 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
} else {
v2Write
}
-
- case u: UpdateTable if !u.skipSchemaResolution && u.resolved =>
Review Comment:
One notable difference is not using `AssertNotNull` and relying on the same
framework we have for V2 tables. In particular, we check the assignment mode
and whether in and out attributes are compatible. As a consequence, we get
analysis errors and not runtime errors.
However, the main contribution of this PR is `AssignmentUtils` that aligns
assignments with table attributes. It is a prerequisite for rewriting UPDATEs.
Right now, we only rewrite DELETEs. The new utility also handles casts and
char/varchar types, which we already did here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
