[GitHub] [spark] srielau commented on a diff in pull request #40333: [SPARK-42702][SPARK-42623][SQL] Support parameterized query in subquery and CTE

[via GitHub]

srielau commented on code in PR #40333:
URL: https://github.com/apache/spark/pull/40333#discussion_r1129564083


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1730,6 +1730,11 @@
           "Pandas user defined aggregate function in the PIVOT clause."
         ]
       },
+      "PARAMETERIZED_COMMAND" : {
+        "message" : [
+          "Query parameters in Command."

Review Comment:
   Is "query parameters" a term? I thought we go by "parameter marker". Either 
way we can be more descriptive.
   
   ```suggestion
             "Parameter markers in a DDL statement. Parameter markers must only 
be used in a query, or DML statement. Usage within CREATE or ALTER is 
unsupported."
   ```



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1730,6 +1730,11 @@
           "Pandas user defined aggregate function in the PIVOT clause."
         ]
       },
+      "PARAMETERIZED_COMMAND" : {

Review Comment:
   ```suggestion
         "PARAMETERIZED_DDL" : {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org