aokolnychyi commented on code in PR #40308:
URL: https://github.com/apache/spark/pull/40308#discussion_r1131921529
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3344,43 +3345,6 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
} else {
v2Write
}
-
- case u: UpdateTable if !u.skipSchemaResolution && u.resolved =>
Review Comment:
I see value in both depending on the use case. What about making it
configurable? If we just switch to runtime checks everywhere, it will be a
substantial behavior change. We can add a new SQL property and default to the
existing INSERT behavior of throwing an exception during the analysis phase.
By the way, I don't target 3.4 in this PR so we will have time to build a
proper runtime checking framework. I think that would be a substantial effort
as we need to cover inner fields, arrays, maps. There is no logic for that at
the moment, if I am not mistaken.
I do think consistency would be important. UPDATE and INSERT should behave
in the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
