cloud-fan commented on PR #40473:
URL: https://github.com/apache/spark/pull/40473#issuecomment-1477165259

   The check was added to `getExprState` in 
https://github.com/apache/spark/pull/39010, which is to avoid canonicalizing a 
subquery expression and leading to NPE.
   
   I agree that we should be consistent and this PR LGTM. Can we update the 
test case to use `LambdaVariable` as `NamedLambdaVariable` has been removed in 
https://github.com/apache/spark/pull/40475 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to