gerashegalov commented on code in PR #40515:
URL: https://github.com/apache/spark/pull/40515#discussion_r1146935415
##########
connector/connect/bin/spark-connect-scala-client:
##########
@@ -46,6 +45,4 @@ build/sbt "${SCALA_ARG}"
"sql/package;connect-client-jvm/assembly"
CONNECT_CLASSPATH="$(build/sbt "${SCALA_ARG}" -DcopyDependencies=false "export
connect-client-jvm/fullClasspath" | grep jar | tail -n1)"
SQL_CLASSPATH="$(build/sbt "${SCALA_ARG}" -DcopyDependencies=false "export
sql/fullClasspath" | grep jar | tail -n1)"
-INIT_SCRIPT="${SPARK_HOME}"/connector/connect/bin/spark-connect-scala-client.sc
-
-exec "${SCALA_BIN}" -cp "$CONNECT_CLASSPATH:$SQL_CLASSPATH" -i $INIT_SCRIPT
+exec java -cp "$CONNECT_CLASSPATH:$SQL_CLASSPATH"
org.apache.spark.sql.application.ConnectRepl "$@"
Review Comment:
did not notice it earlier, Spark scripts prioritize JAVA_HOME
https://github.com/apache/spark/blob/04202b3fdda1ac7aea7d7e5688487ce749ad2f79/bin/spark-class#L27-L36
. Maybe there is a way to leverage this script here to begin with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
