VindhyaG commented on code in PR #40553:
URL: https://github.com/apache/spark/pull/40553#discussion_r1153193529
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -535,6 +535,159 @@ class Dataset[T] private[sql] (
}
}
+ /**
+ * Gets the Dataset as string in a tabular form. Strings more than 20
characters will be
+ * truncated, and all cells will be aligned right. For example:
+ * {{{
+ * year month AVG('Adj Close) MAX('Adj Close)
+ * 1980 12 0.503218 0.595103
+ * 1981 01 0.523289 0.570307
+ * 1982 02 0.436504 0.475256
+ * 1983 03 0.410516 0.442194
+ * 1984 04 0.450090 0.483521
+ * }}}
+ *
+ * @param numRows
+ * Number of rows to show
+ * @group action
+ * @since 3.4.0
Review Comment:
This was added on its own. not sure why?
> Hi @VindhyaG, this might be useful - may be we can benefit from the
usecase you have for this. Is it just for logging? Not sure what others think,
it might be good to limit the API surface.
@ScrapCodes Thanks for reviewing. bug lists the three reasons which i have
listed in PR description above. Do you have any specific suggestions to limit
API surface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
