LuciferYang commented on code in PR #40613:
URL: https://github.com/apache/spark/pull/40613#discussion_r1153957872
##########
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java:
##########
@@ -243,7 +243,9 @@ protected void serviceInit(Configuration externalConf)
throws Exception {
boolean stopOnFailure = _conf.getBoolean(STOP_ON_FAILURE_KEY,
DEFAULT_STOP_ON_FAILURE);
if (_recoveryPath == null && _conf.getBoolean(INTEGRATION_TESTING, false))
{
- _recoveryPath = new Path(JavaUtils.createTempDir().toURI());
+ File tempDir =
JavaUtils.createDirectory(System.getProperty("java.io.tmpdir"), "spark");
Review Comment:
A test only code path, so I think `deleteOnExit` is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
