cloud-fan commented on code in PR #40602:
URL: https://github.com/apache/spark/pull/40602#discussion_r1153980662
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala:
##########
@@ -113,8 +114,9 @@ private object DB2Dialect extends JdbcDialect {
// scalastyle:off line.size.limit
// See
https://www.ibm.com/support/knowledgecenter/en/SSEPGG_11.5.0/com.ibm.db2.luw.sql.ref.doc/doc/r0000980.html
// scalastyle:on line.size.limit
- override def renameTable(oldTable: String, newTable: String): String = {
- s"RENAME TABLE $oldTable TO $newTable"
+ override def renameTable(oldTable: Identifier, newTable: Identifier): String
= {
+ s" RENAME TABLE ${getFullyQualifiedQuotedTableName(oldTable)} TO " +
Review Comment:
nit: why do we put a space at the beginning?
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala:
##########
@@ -63,8 +64,9 @@ private case object TeradataDialect extends JdbcDialect {
}
// See
https://docs.teradata.com/reader/scPHvjfglIlB8F70YliLAw/wysTNUMsP~0aGzksLCl1kg
- override def renameTable(oldTable: String, newTable: String): String = {
- s"RENAME TABLE $oldTable TO $newTable"
+ override def renameTable(oldTable: Identifier, newTable: Identifier): String
= {
+ s" RENAME TABLE ${getFullyQualifiedQuotedTableName(oldTable)} TO " +
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
