cloud-fan commented on PR #32987: URL: https://github.com/apache/spark/pull/32987#issuecomment-1491247967
After taking another thought, I think the idea is valid. If a subexpression will be evaluated at least once, and likely more than once due to conditional branches, it should be beneficial to do CSE. The worst case is we never evaluate the subexpression within the conditional branches, and take the overhead of not inlining the subexpression. But this should be a corner case. cc @rednaxelafx @ulysses-you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
