Hisoka-X commented on code in PR #40564:
URL: https://github.com/apache/spark/pull/40564#discussion_r1155047034
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryBaseTable.scala:
##########
@@ -434,7 +433,9 @@ abstract class InMemoryBaseTable(
protected var streamingWriter: StreamingWrite = StreamingAppend
override def overwriteDynamicPartitions(): WriteBuilder = {
- assert(writer == Append)
+ if (writer != Append) {
Review Comment:
The reason is we want to use catalyst test jar to submit ConnectService, so
we can use `InMemoryTableCatalog`. But if `scalatest` used by
`InMemoryTableCatalog`. We should add `scalatest` jar into ConnectService too.
So I remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
