hvanhovell commented on code in PR #40605:
URL: https://github.com/apache/spark/pull/40605#discussion_r1160381455
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala:
##########
@@ -62,15 +62,29 @@ object CheckConnectJvmClientCompatibility {
"spark-connect-client-jvm-assembly",
"spark-connect-client-jvm")
val sqlJar: File = findJar("sql/core", "spark-sql", "spark-sql")
- val problems = checkMiMaCompatibility(clientJar, sqlJar)
- if (problems.nonEmpty) {
+ val problemsWithSqlModule =
checkMiMaCompatibilityWithSqlModule(clientJar, sqlJar)
+ if (problemsWithSqlModule.nonEmpty) {
resultWriter.write(s"ERROR: Comparing client jar: $clientJar and and
sql jar: $sqlJar \n")
- resultWriter.write(s"problems: \n")
- resultWriter.write(s"${problems.map(p =>
p.description("client")).mkString("\n")}")
+ resultWriter.write(s"problemsWithSqlModule: \n")
Review Comment:
Let's add a helper function for the problem logging. Also use multiline
strings there, they tend to be easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
