Yikf commented on PR #40437: URL: https://github.com/apache/spark/pull/40437#issuecomment-1499861262
> Seems like we just need a small change: only invoke `hiveResultString` if a testing config is true, and we only set that testing config in `HiveComparisonTest`. Return the result as a hive compatible sequence of strings of `hiveResultString` currently does two things: 1. `HiveComparisonTest` used to compare compatibility with hive output; 2. Spark generates golden files for `SQLQueryTestSuite`; 2 is a friendly form of output, and I think we should keep it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
