grundprinzip commented on code in PR #40695:
URL: https://github.com/apache/spark/pull/40695#discussion_r1161423539
##########
python/pyspark/sql/connect/client.py:
##########
@@ -867,6 +878,8 @@ def _analyze(self, method: str, **kwargs: Any) ->
AnalyzeResult:
req.unpersist.blocking = cast(bool, kwargs.get("blocking"))
elif method == "get_storage_level":
req.get_storage_level.relation.CopyFrom(cast(pb2.Relation,
kwargs.get("relation")))
+ elif method == "resources":
Review Comment:
It's the same issue. I don't appreciate the way it was implemented. The
analyze RPC has no semantic relationship to either version nor resources.
Please change the resources now as it's too late for version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
