cloud-fan commented on code in PR #40688: URL: https://github.com/apache/spark/pull/40688#discussion_r1161444242
########## sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala: ########## @@ -118,6 +118,7 @@ case class AdaptiveSparkPlanExec( val ensureRequirements = EnsureRequirements(requiredDistribution.isDefined, requiredDistribution) Seq( + CoalesceBucketsInJoin, Review Comment: rules in `queryStageOptimizerRules` are invoked less often which is more efficient. The rule `CoalesceBucketsInJoin` does not change plan partitioning and seems can be put in `queryStageOptimizerRules` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org