dtenedor commented on code in PR #40732:
URL: https://github.com/apache/spark/pull/40732#discussion_r1165853739
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDefaultColumns.scala:
##########
@@ -47,9 +47,10 @@ import org.apache.spark.sql.types._
* (1, 5)
* (4, 6)
*
- * @param catalog the catalog to use for looking up the schema of INSERT INTO
table objects.
+ * @param resolveRelations rule to resolve relations from the catalog. This
should generally map to
+ * the the ResolveRelations analyzer rule.
*/
-case class ResolveDefaultColumns(catalog: SessionCatalog) extends
Rule[LogicalPlan] {
+case class ResolveDefaultColumns(resolveRelations: Rule[LogicalPlan]) extends
Rule[LogicalPlan] {
Review Comment:
Sure, I added a new method in `ResolveRelations` for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
