sunchao commented on code in PR #40701:
URL: https://github.com/apache/spark/pull/40701#discussion_r1166126541
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLDriver.scala:
##########
@@ -65,8 +66,15 @@ private[hive] class SparkSQLDriver(val context: SQLContext =
SparkSQLEnv.sqlCont
}
context.sparkContext.setJobDescription(substitutorCommand)
val execution =
context.sessionState.executePlan(context.sql(command).logicalPlan)
- hiveResponse = SQLExecution.withNewExecutionId(execution, Some("cli")) {
- hiveResultString(execution.executedPlan)
+ // Command type sql have been executed when call
`context.sql(command).logicalPlan`,
Review Comment:
this comment is not very easy to understand: what is `Command type sql"?
maybe:
```
The SQL command has been executed above via `executePlan`, therefore we
don't need to wrap it again
with a new execution ID when getting Hive result
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
