LuciferYang commented on code in PR #40610:
URL: https://github.com/apache/spark/pull/40610#discussion_r1168218532
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkResult.scala:
##########
@@ -142,24 +150,41 @@ private[sql] class SparkResult[T](
/**
* Returns an iterator over the contents of the result.
*/
- def iterator: java.util.Iterator[T] with AutoCloseable = {
+ def iterator: java.util.Iterator[T] with AutoCloseable =
+ buildIterator(destructive = false)
+
+ /**
+ * Returns an destructive iterator over the contents of the result.
+ */
+ def destructiveIterator: java.util.Iterator[T] with AutoCloseable =
+ buildIterator(destructive = true)
+
+ private def buildIterator(destructive: Boolean): java.util.Iterator[T] with
AutoCloseable = {
new java.util.Iterator[T] with AutoCloseable {
private[this] var batchIndex: Int = -1
private[this] var iterator: java.util.Iterator[InternalRow] =
Collections.emptyIterator()
private[this] var deserializer: Deserializer[T] = _
+
override def hasNext: Boolean = {
if (iterator.hasNext) {
return true
}
+
val nextBatchIndex = batchIndex + 1
- val hasNextBatch = if (nextBatchIndex == batches.size) {
+ if (destructive && idxToBatches.contains(batchIndex)) {
+ val currentBatch = idxToBatches(batchIndex)
Review Comment:
if `currentBatch` just used to close `ColumnarBatch`, how about
```
if (destructive) {
idxToBatches.remove(batchIndex).foreach(_.close())
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
