Hisoka-X commented on PR #40865: URL: https://github.com/apache/spark/pull/40865#issuecomment-1517521661
> @Hisoka-X do you mean the bug is already fixed now? Depends on what is correct results of `select *, (select any_value(false) as result from t1 where t0.a = t1.c) from t0)` ? > if the subquery is something like select false from ... group by c then it will still actually return null on empty inputs. The current state is as described by @jchen5 . `select false from ... group by c` will result null on empty inputs, not return `false`. I think this is what @jchen5 worry about. You can check by https://github.com/apache/spark/pull/40865#discussion_r1173210161 . If you think `select false from ... group by c` in subquery should return `false` on empty inputs, this PR have bug now. If you think it should return `null` on empty inputs, this PR are correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
