itholic commented on code in PR #40722:
URL: https://github.com/apache/spark/pull/40722#discussion_r1178559820
##########
python/pyspark/pandas/internal.py:
##########
@@ -628,7 +624,13 @@ def __init__(
>>> internal.column_label_names
[('column_labels_a',), ('column_labels_b',)]
"""
- assert isinstance(spark_frame, GenericDataFrame.__args__) # type:
ignore[attr-defined]
Review Comment:
Yes, I believe they works as the same, because
- `GenericDataFrame.__args__` was returning `(<class
'pyspark.sql.dataframe.DataFrame'>, <class
'pyspark.sql.connect.dataframe.DataFrame'>)`
- `SparkDataFrame` now indicates `pyspark.sql.dataframe.DataFrame` or
`pyspark.sql.connect.dataframe.DataFrame`
so both can check the same condition. Please let me know if I missed
something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
