juliuszsompolski commented on code in PR #41005: URL: https://github.com/apache/spark/pull/41005#discussion_r1182420149
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connect.service + +import java.util.UUID +import java.util.concurrent.{ConcurrentHashMap, ConcurrentMap} + +import collection.JavaConverters._ + +import org.apache.spark.connect.proto +import org.apache.spark.sql.SparkSession + +/** + * Object used to hold the Spark Connect session state. + */ +case class SessionHolder( + userId: String, + sessionId: String, + session: SparkSession) { + + val executePlanOperations: ConcurrentMap[String, ExecutePlanHolder] = Review Comment: It's not strictly needed at this very moment, but this is a foundation needed for the immediate followup work of actually detaching the execution from the RPC handler described in the PR description. This is then needed both for future interrupt one, and I'd like to set this foundation to make it easier for followup work without running into conflicting changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
