WweiL commented on code in PR #41026:
URL: https://github.com/apache/spark/pull/41026#discussion_r1184223920
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -209,6 +209,15 @@ message WriteStreamOperationStart {
string path = 11;
string table_name = 12;
}
+
+ optional Foreach foreach = 13;
+}
+
+message Foreach {
+ // (Required) The encoded commands of the Python foreach function
+ bytes command = 1;
Review Comment:
Right we can reuse. But I think foreach conceptually doesn't belong to
`PythonUDF`. We probably need to refactor this, maybe in a follow-up PR? I'm
thinking that there probably needs to be a more general `message
PythonFunction` that wraps all info, and `PythonUDF` could just wrap around it
and here we could just use it. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
