bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1537522027
Reboot and run with `sbt 'jmh:run -i 10 -wi 10 -f 1 -t 1'`
with
"com.google.crypto.tink" % "tink" % "1.9.0"
```
[info] compiling 5 Java sources to
/home/bjorn/Documents/github/GoogleThinkBenchmark/target/scala-2.12/classes ...
[info] running (fork) org.openjdk.jmh.Main -i 10 -wi 10 -f 1 -t 1
[info] # JMH version: 1.31
[info] # VM version: JDK 17.0.6, OpenJDK 64-Bit Server VM,
17.0.6+10-Ubuntu-1ubuntu2
[info] # VM invoker: /usr/lib/jvm/java-17-openjdk-amd64/bin/java
[info] # VM options: <none>
[info] # Blackhole mode: full + dont-inline hint
[info] # Warmup: 10 iterations, 10 s each
[info] # Measurement: 10 iterations, 10 s each
[info] # Timeout: 10 min per iteration
[info] # Threads: 1 thread, will synchronize iterations
[info] # Benchmark mode: Average time, time/op
[info] # Benchmark:
com.googlethinkbenchmark.GoogleThinkBenchmark.testAesGcmJceEncrypt
[info] # Run progress: 0.00% complete, ETA 00:03:20
[info] # Fork: 1 of 1
[info] # Warmup Iteration 1: 83028380.132 ns/op
[info] # Warmup Iteration 2: 78802359.000 ns/op
[info] # Warmup Iteration 3: 79210527.969 ns/op
[info] # Warmup Iteration 4: 78695687.141 ns/op
[info] # Warmup Iteration 5: 78938831.701 ns/op
[info] # Warmup Iteration 6: 78575255.695 ns/op
[info] # Warmup Iteration 7: 79112203.724 ns/op
[info] # Warmup Iteration 8: 79323400.079 ns/op
[info] # Warmup Iteration 9: 78537590.867 ns/op
[info] # Warmup Iteration 10: 78413295.234 ns/op
[info] Iteration 1: 77933768.721 ns/op
[info] Iteration 2: 79192640.055 ns/op
[info] Iteration 3: 79182903.512 ns/op
[info] Iteration 4: 79111605.283 ns/op
[info] Iteration 5: 78859743.535 ns/op
[info] Iteration 6: 78318937.016 ns/op
[info] Iteration 7: 77986910.411 ns/op
[info] Iteration 8: 78648235.734 ns/op
[info] Iteration 9: 78609703.445 ns/op
[info] Iteration 10: 79423429.968 ns/op
[info] Result
"com.googlethinkbenchmark.GoogleThinkBenchmark.testAesGcmJceEncrypt":
[info] 78726787.768 ±(99.9%) 786981.254 ns/op [Average]
[info] (min, avg, max) = (77933768.721, 78726787.768, 79423429.968), stdev
= 520539.373
[info] CI (99.9%): [77939806.514, 79513769.022] (assumes normal
distribution)
[info] # Run complete. Total time: 00:03:21
[info] REMEMBER: The numbers below are just data. To gain reusable insights,
you need to follow up on
[info] why the numbers are the way they are. Use profilers (see -prof,
-lprof), design factorial
[info] experiments, perform baseline and negative tests that provide
experimental control, make sure
[info] the benchmarking environment is safe on JVM/OS/HW level, ask for
reviews from the domain experts.
[info] Do not assume the numbers tell you what you want them to tell.
[info] Benchmark Mode Cnt Score
Error Units
[info] GoogleThinkBenchmark.testAesGcmJceEncrypt avgt 10 78726787.768 ±
786981.254 ns/op
```
with
"com.google.crypto.tink" % "tink" % "1.6.1"
```
[info] compiling 5 Java sources to
/home/bjorn/Documents/github/GoogleThinkBenchmark/target/scala-2.12/classes ...
[info] running (fork) org.openjdk.jmh.Main -i 10 -wi 10 -f 1 -t 1
[info] # JMH version: 1.31
[info] # VM version: JDK 17.0.6, OpenJDK 64-Bit Server VM,
17.0.6+10-Ubuntu-1ubuntu2
[info] # VM invoker: /usr/lib/jvm/java-17-openjdk-amd64/bin/java
[info] # VM options: <none>
[info] # Blackhole mode: full + dont-inline hint
[info] # Warmup: 10 iterations, 10 s each
[info] # Measurement: 10 iterations, 10 s each
[info] # Timeout: 10 min per iteration
[info] # Threads: 1 thread, will synchronize iterations
[info] # Benchmark mode: Average time, time/op
[info] # Benchmark:
com.googlethinkbenchmark.GoogleThinkBenchmark.testAesGcmJceEncrypt
[info] # Run progress: 0.00% complete, ETA 00:03:20
[info] # Fork: 1 of 1
[info] # Warmup Iteration 1: 83260488.298 ns/op
[info] # Warmup Iteration 2: 77947987.496 ns/op
[info] # Warmup Iteration 3: 78086226.109 ns/op
[info] # Warmup Iteration 4: 76767415.580 ns/op
[info] # Warmup Iteration 5: 76449646.229 ns/op
[info] # Warmup Iteration 6: 78385935.750 ns/op
[info] # Warmup Iteration 7: 77999410.016 ns/op
[info] # Warmup Iteration 8: 76971635.577 ns/op
[info] # Warmup Iteration 9: 76934072.685 ns/op
[info] # Warmup Iteration 10: 77180919.354 ns/op
[info] Iteration 1: 76979372.431 ns/op
[info] Iteration 2: 76777254.260 ns/op
[info] Iteration 3: 76748232.038 ns/op
[info] Iteration 4: 77181769.492 ns/op
[info] Iteration 5: 78160841.664 ns/op
[info] Iteration 6: 77396535.208 ns/op
[info] Iteration 7: 77519909.492 ns/op
[info] Iteration 8: 77570303.233 ns/op
[info] Iteration 9: 77661022.992 ns/op
[info] Iteration 10: 78231386.313 ns/op
[info] Result
"com.googlethinkbenchmark.GoogleThinkBenchmark.testAesGcmJceEncrypt":
[info] 77422662.712 ±(99.9%) 782935.090 ns/op [Average]
[info] (min, avg, max) = (76748232.038, 77422662.712, 78231386.313), stdev
= 517863.085
[info] CI (99.9%): [76639727.623, 78205597.802] (assumes normal
distribution)
[info] # Run complete. Total time: 00:03:21
[info] REMEMBER: The numbers below are just data. To gain reusable insights,
you need to follow up on
[info] why the numbers are the way they are. Use profilers (see -prof,
-lprof), design factorial
[info] experiments, perform baseline and negative tests that provide
experimental control, make sure
[info] the benchmarking environment is safe on JVM/OS/HW level, ask for
reviews from the domain experts.
[info] Do not assume the numbers tell you what you want them to tell.
[info] Benchmark Mode Cnt Score
Error Units
[info] GoogleThinkBenchmark.testAesGcmJceEncrypt avgt 10 77422662.712 ±
782935.090 ns/op
[success] Total time: 207 s (03:27), completed May 7, 2023, 9:13:15 PM
```
Almost the same.. Think 1.9.0 is perhaps a bit slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
