dtenedor opened a new pull request, #41191:
URL: https://github.com/apache/spark/pull/41191

   ### What changes were proposed in this pull request?
   
   This PR updates the SQL parser to support general expressions in the syntax 
for OPTIONS values, rather than restricting to a few types of literals only.
   
   * For now, the `AstBuilder` manually checks that the provided expressions 
are in fact literals, and throws an error message otherwise.
   * In the future, we can expand to support other types of expressions as well.
   * In the interim, the error message that users encounter in these cases 
improves from a general "syntax error at or near <location>" to instead 
indicate that the syntax is valid, but only literals are supported in these 
contexts.
   
   ### Why are the changes needed?
   
   This makes it possible to allow more features in this area in the future, 
such as accepting constant but non-literal expression trees and then 
constant-folding them.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, the SQL syntax changes.
   
   ### How was this patch tested?
   
   This PR adds new unit test coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to