dongjoon-hyun commented on code in PR #41201: URL: https://github.com/apache/spark/pull/41201#discussion_r1196696629
########## core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala: ########## @@ -1618,6 +1618,24 @@ class SparkSubmitSuite conf.get(k) should be (v) } } + + test("SPARK-43540: Add working directory into classpath on the driver in K8S cluster mode") { + val clArgs = Seq( + "--deploy-mode", "client", + "--proxy-user", "test.user", + "--master", "k8s://host:port", + "--executor-memory", "5g", + "--class", "org.SomeClass", + "--driver-memory", "4g", + "--conf", "spark.kubernetes.namespace=spark", + "--conf", "spark.kubernetes.driver.container.image=bar", + "--conf", "spark.kubernetes.submitInDriver=true", + "/home/thejar.jar", + "arg1") Review Comment: Thank you for making a PR. BTW, do we need 11 lines to assert `classpath`? Do you think you can minimize this test case like the existing test cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org