rangadi commented on code in PR #41192:
URL: https://github.com/apache/spark/pull/41192#discussion_r1198582814
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/protobuf/functions.scala:
##########
@@ -45,12 +53,36 @@ object functions {
messageName: String,
descFilePath: String,
options: java.util.Map[String, String]): Column = {
+ val binaryFileDescSet = readDescriptorFileContent(descFilePath)
Review Comment:
@LuciferYang I updated connect functions to use the buffer and change the
protocol to send the buffer to the server rather the file name (as a result the
file is only read on the client side).
Updated the tests and added a ClientE2E test. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
