dtenedor commented on code in PR #41191: URL: https://github.com/apache/spark/pull/41191#discussion_r1203242441
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ResolveTableSpec.scala: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.catalyst.optimizer.ConstantFolding +import org.apache.spark.sql.catalyst.plans.logical._ +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.catalyst.trees.TreePattern.COMMAND +import org.apache.spark.sql.connector.catalog.CatalogManager + +/** + * This rule is responsible for analyzing expressions passed in as values for OPTIONS lists for + * commands such as CREATE TABLE. These expressions may be constant but non-literal, in which case + * we perform constant folding here. + */ +case class ResolveTableSpec(catalogManager: CatalogManager) extends Rule[LogicalPlan] { Review Comment: Sounds good, done! ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ########## @@ -1389,4 +1389,8 @@ case class TableSpec( location: Option[String], comment: Option[String], serde: Option[SerdeInfo], - external: Boolean) + external: Boolean, + // If non-empty, this contains the values of the 'options' list as parsed but unresolved + // expressions. The analyzer will then constant-fold them to literals and clear this field, + // assigning the result to 'options'. + unresolvedOptions: Map[String, Option[Expression]] = Map.empty) Review Comment: We talked offline, I changed it to `Map[String, Expression]` per this suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
