WweiL commented on code in PR #41129:
URL: https://github.com/apache/spark/pull/41129#discussion_r1205890454
##########
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala:
##########
@@ -451,13 +451,17 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
foreachImplementation(writer.asInstanceOf[ForeachWriter[Any]])
}
- private[sql] def foreachImplementation(writer: ForeachWriter[Any]):
DataStreamWriter[T] = {
+ private[sql] def foreachImplementation(writer: ForeachWriter[Any],
+ encoder: Either[ExpressionEncoder[Any], InternalRow => Any] = null):
DataStreamWriter[T] = {
Review Comment:
Also I think even with only primitive types the encoder is still needed. Let
me test it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
