gengliangwang commented on code in PR #41191: URL: https://github.com/apache/spark/pull/41191#discussion_r1209789661
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableSpec.scala: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.SparkThrowable +import org.apache.spark.sql.catalyst.expressions.{Expression, Literal} +import org.apache.spark.sql.catalyst.plans.logical._ +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.catalyst.trees.TreePattern.COMMAND +import org.apache.spark.sql.errors.QueryCompilationErrors + +/** + * This rule is responsible for matching against unresolved table specifications in commands with + * OPTIONS lists. The parser produces such lists as maps from strings to unresolved expressions. + * After otherwise resolving such expressions in the analyzer, this rule converts them to resolved + * table specifications wherein these OPTIONS list values are represented as strings instead, for + * convenience. The 'resolveOption' is for resolving function calls within each table option. + */ +case class ResolveTableSpec(resolveOption: Expression => Expression) extends Rule[LogicalPlan] { + override def apply(plan: LogicalPlan): LogicalPlan = { + plan.resolveOperatorsWithPruning(_.containsAnyPattern(COMMAND), ruleId) { + case t: CreateTable if t.tableSpec.isInstanceOf[UnresolvedTableSpec] => + t.copy(tableSpec = resolveTableSpec(t.tableSpec)) + case t: CreateTableAsSelect if t.tableSpec.isInstanceOf[UnresolvedTableSpec] => + t.copy(tableSpec = resolveTableSpec(t.tableSpec)) + case t: ReplaceTable if t.tableSpec.isInstanceOf[UnresolvedTableSpec] => + t.copy(tableSpec = resolveTableSpec(t.tableSpec)) + case t: ReplaceTableAsSelect if t.tableSpec.isInstanceOf[UnresolvedTableSpec] => + t.copy(tableSpec = resolveTableSpec(t.tableSpec)) + } + } + + private def resolveTableSpec(t: TableSpec): TableSpec = { + val u = t.asInstanceOf[UnresolvedTableSpec] + val newOptions: Map[String, String] = u.optionsExpressions.map { + case (key: String, null) => + (key, null) + case (key: String, value: Expression) => + val newValue: String = try { + resolveOption(value) match { + case lit: Literal => Review Comment: Do we need error handling if the resolve result is not literal? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
