shuyouZZ commented on code in PR #41491:
URL: https://github.com/apache/spark/pull/41491#discussion_r1222636986
##########
core/src/main/scala/org/apache/spark/deploy/history/EventLogFileCompactor.scala:
##########
@@ -221,5 +222,15 @@ private class CompactedEventLogFileWriter(
hadoopConf: Configuration)
extends SingleEventLogFileWriter(appId, appAttemptId, logBaseDir, sparkConf,
hadoopConf) {
- override val logPath: String = originalFilePath.toUri.toString +
EventLogFileWriter.COMPACTED
+ override val shouldCompress =
EventLogFileWriter.codecName(originalFilePath).isDefined
Review Comment:
> BTW, `EventLogFileWriter.codecName(originalFilePath)` is used twice here
and line 229. Could you make a private val and reuse it?
has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
