Hisoka-X commented on code in PR #41496:
URL: https://github.com/apache/spark/pull/41496#discussion_r1222908269
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala:
##########
@@ -440,14 +476,49 @@ trait SQLInsertTestSuite extends QueryTest with
SQLTestUtils {
}
class FileSourceSQLInsertTestSuite extends SQLInsertTestSuite with
SharedSparkSession {
+
+ import testImplicits._
+
override def format: String = "parquet"
+
override protected def sparkConf: SparkConf = {
super.sparkConf.set(SQLConf.USE_V1_SOURCE_LIST, format)
}
+
+ test("insert by name: mismatch column name") {
Review Comment:
I think there are something wrong in
[`TableOutputResolver`](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala#L231).
The `newColPath` will be empty. But it has nothing to do with this PR.
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala:
##########
@@ -440,14 +476,49 @@ trait SQLInsertTestSuite extends QueryTest with
SQLTestUtils {
}
class FileSourceSQLInsertTestSuite extends SQLInsertTestSuite with
SharedSparkSession {
+
+ import testImplicits._
+
override def format: String = "parquet"
+
override protected def sparkConf: SparkConf = {
super.sparkConf.set(SQLConf.USE_V1_SOURCE_LIST, format)
}
+
+ test("insert by name: mismatch column name") {
Review Comment:
I think there are something wrong in
[`TableOutputResolver`](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala#L231).
The `colPath` will be empty. But it has nothing to do with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
