rangadi commented on code in PR #41498: URL: https://github.com/apache/spark/pull/41498#discussion_r1223373565
########## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/ProtobufDeserializer.scala: ########## @@ -247,12 +247,86 @@ private[sql] class ProtobufDeserializer( updater.setLong(ordinal, micros + TimeUnit.NANOSECONDS.toMicros(nanoSeconds)) case (MESSAGE, StringType) - if protoType.getMessageType.getFullName == "google.protobuf.Any" => + if protoType.getMessageType.getFullName == "google.protobuf.Any" => (updater, ordinal, value) => // Convert 'Any' protobuf message to JSON string. val jsonStr = jsonPrinter.print(value.asInstanceOf[DynamicMessage]) updater.set(ordinal, UTF8String.fromString(jsonStr)) + // Handle well known wrapper types. We unpack the value field instead of keeping Review Comment: > Did you check the PR description? Theres an example of what the deserialization would look like before and after. Beyond that, i'm not sure what kind of example would help... Could you be specific in what you're looking for here? I know what the PR does. Not looking for example usage. Looking for motivating example that shows the need to have this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org