zhengruifeng commented on code in PR #41505:
URL: https://github.com/apache/spark/pull/41505#discussion_r1223802204
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -1964,6 +1964,34 @@ class PlanGenerationTestSuite
fn.to_csv(fn.col("d"), Collections.singletonMap("sep", "|"))
}
+ functionTest("str_to_map") {
Review Comment:
please also add test for
`def str_to_map(text: Column, pairDelim: Column)`
`def str_to_map(text: Column): Column`
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala:
##########
@@ -1964,6 +1964,34 @@ class PlanGenerationTestSuite
fn.to_csv(fn.col("d"), Collections.singletonMap("sep", "|"))
}
+ functionTest("str_to_map") {
+ fn.str_to_map(fn.col("g"))
+ }
+
+ functionTest("to_binary") {
Review Comment:
test `def to_binary(e: Column)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
