siying commented on code in PR #41578: URL: https://github.com/apache/spark/pull/41578#discussion_r1230132531
########## sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala: ########## @@ -684,6 +685,26 @@ class StreamSuite extends StreamTest { assert(query.exception.isEmpty) } + test("SPARK-44044: non-time-window") { + val inputData = MemoryStream[(Int, Int)] + val e = intercept[AnalysisException] { + val agg = inputData + .toDF() + .selectExpr("CAST(_1 AS timestamp) AS col1", "_2 AS col2") + .withWatermark("col1", "10 seconds") + .withColumn("rn_col", row_number().over(Window + .partitionBy("col1") + .orderBy(col("col2")))) + .select("rn_col", "col1", "col2") + .writeStream + .format("console") + .start() + } + assert(e.getMessage.contains( + "Unsupported window function found in column 'row_number() AS rn_col'")) Review Comment: Updated the PR. Now the message looks like following: ``` Unsupported window function in 'row_number()' as column 'rn_col'. Structured Streaming only supports time-window aggregation using the `window` function. (window specification: (PARTITION BY col1 ORDER BY col2 ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org