zhengruifeng commented on code in PR #41931: URL: https://github.com/apache/spark/pull/41931#discussion_r1259403299
########## python/pyspark/pandas/sql_formatter.py: ########## @@ -265,7 +266,14 @@ def _convert_value(self, val: Any, name: str) -> Optional[str]: val._to_spark().createOrReplaceTempView(df_name) return df_name elif isinstance(val, str): - return lit(val)._jc.expr().sql() # for escaped characters. + if is_remote(): + special_characters = ["\\", "'", '"', "\0", "\b", "\n", "\r", "\t"] Review Comment: let's exactly match `"'" + v.toString.replace("\\", "\\\\").replace("'", "\\'") + "'"` in the JVM side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org