HyukjinKwon commented on code in PR #41748:
URL: https://github.com/apache/spark/pull/41748#discussion_r1260350104
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala:
##########
@@ -163,19 +172,27 @@ class QueryExecution(
}
}
+ private[sql] def assertSparkPlanPrepared(): Unit = sparkPlan
+
// executedPlan should not be used to initialize any SparkPlan. It should be
// only used for execution.
lazy val executedPlan: SparkPlan = {
// We need to materialize the optimizedPlan here, before tracking the
planning phase, to ensure
// that the optimization time is not counted as part of the planning phase.
assertOptimized()
- executePhase(QueryPlanningTracker.PLANNING) {
+ val plan = executePhase(QueryPlanningTracker.PLANNING) {
// clone the plan to avoid sharing the plan instance between different
stages like analyzing,
// optimizing and planning.
QueryExecution.prepareForExecution(preparations, sparkPlan.clone())
}
+ // Note: For eagerly executed command it might have already been called in
+ // `eagerlyExecutedCommand` and is a noop here.
+ tracker.setReadyForExecution()
+ plan
}
+ def assertExecutedPlanPrepared(): Unit = executedPlan
Review Comment:
```suggestion
private[sql] def assertExecutedPlanPrepared(): Unit = executedPlan
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
