eejbyfeldt commented on PR #41943: URL: https://github.com/apache/spark/pull/41943#issuecomment-1631892085
> @eejbyfeldt Do you know why SBT is not failed? The failures are not directly related to scala 2.13.11. They are caused by the maven plugin we are using for running scalac. For versions greater or equal to `2.13.9` that plugin sets `-release` instead of `-target` (https://github.com/davidB/scala-maven-plugin/blob/4.8.0/src/main/java/scala_maven/ScalaMojoSupport.java#L629-L648) And as noted https://github.com/scala/bug/issues/12643 and https://github.com/scala/bug/issues/12824 replacing `-target` with `-release` is **not** a noop and has slightly different meaning and behvaior. My unserstanding in that in the sbt build we only set `-target` and we do not use `-release` and therefore we do not run into the same issues with the sbt build. > A quick question: previously, the output artifacts are runnable on JDK 8 whatever the building JDK version is. is it true after this change? Based on the example provided in https://github.com/scala/bug/issues/12824 that using `-target:8` on java 17 is unsafe and can cause runtime failures. I am not sure we actually had that guarantee before. That said as long as one does not override `java.version` my understanding is that we get the same behavior as before and therefore the same compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
