Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6361#issuecomment-104782414
One high-level comment: is there any way to add tests for this? Since none
of the old tests failed before this patch, I'm concerned that we won't be able
to keep this from breaking in the future. Could you maybe add a new regression
test or suite which tries to run an end-to-end job that uses Kryo as the
closure serializer and verify that this test failed with the old code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
