vicennial commented on code in PR #42069:
URL: https://github.com/apache/spark/pull/42069#discussion_r1267729075
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -860,6 +860,14 @@ private[spark] class Executor(
}
}
+ private def getIsolatedSession(
+ taskDescription: TaskDescription) = {
+ taskDescription.artifacts.state match {
+ case Some(jobArtifactState) =>
+ isolatedSessionCache.get(jobArtifactState.uuid, () =>
newSessionState(jobArtifactState))
+ case _ => defaultSessionState
+ }
+ }
Review Comment:
Nit: This refactoring is unnecessary here. This also modifies [OSS-synced
code](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/executor/Executor.scala#L516-L521)
so we should leave it as it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
